Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for actions full-height CSS #22883

Closed
jolheiser opened this issue Feb 13, 2023 · 3 comments · Fixed by #22885 or #22905
Closed

Tracking issue for actions full-height CSS #22883

jolheiser opened this issue Feb 13, 2023 · 3 comments · Fixed by #22885 or #22905
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.19.0

Comments

@jolheiser
Copy link
Member

Description

gitea/web_src/less/_actions.less

Lines 3 to 6 in be93e48

// TODO: the parent element's full height doesn't work well now
body > div.full.height {
padding-bottom: 0;
}

Screenshots

image

image

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox
@jolheiser jolheiser added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 13, 2023
@jolheiser jolheiser added this to the 1.19.0 milestone Feb 13, 2023
@wxiaoguang
Copy link
Contributor

I do not know why it goes to the _actions.less and polluted the global styles.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 13, 2023 •
edited
Loading

OK, I think I know the problem now, it's caused by this review:

delvh on Jan 3
Why not in one of the normal _$NAME.less files, at best something like _actions.less?

These CSS styles were put in RepoActionView.vue by design (to avoid global pollution) @delvh

@wolfogre wolfogre mentioned this issue Feb 13, 2023
Merged
jolheiser pushed a commit that referenced this issue Feb 13, 2023
@wolfogre
Remove _actions.less (#22885)
00b18ab 
Fix #22883.

Revert commit 59beb2d.
@wxiaoguang wxiaoguang mentioned this issue Feb 14, 2023
Closed
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 14, 2023 •
edited
Loading

Oh sorry that this problem isn't fixed yet.

I think I didn't make it clear enough at the beginning. I will take a look at the problem.

Update: Fix the full-height problem for all pages #22905

@wxiaoguang wxiaoguang mentioned this issue Feb 14, 2023
Merged
lunny added a commit that referenced this issue Feb 14, 2023
@wxiaoguang @lunny
Fix the full-height problem for all pages (#22905)
e314c9e 
Really fix #22883, close #22901

I made a mistake that the global styles in RepoActionView.vue could
still pollute global styles (I forgot that the code of this component is
still loaded on every page, instead of loaded on demand)

This PR makes a complete fix: only change the page's full-height
behavior if the component is used.

Screenshot after the fix:

<details>

![image](https://user-images.githubusercontent.com/2114189/218664776-0dbcd469-2c36-4e17-972f-e44fa3b81ba6.png)

</details>

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Remove _actions.less
Fix the full-height problem for all pages wxiaoguang/gitea
2 participants
@wxiaoguang @jolheiser