Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Interactive time tooltip are not accessible #23645

Closed
fsologureng opened this issue Mar 22, 2023 · 2 comments · Fixed by #23661
Closed

[A11Y] Interactive time tooltip are not accessible #23645

fsologureng opened this issue Mar 22, 2023 · 2 comments · Fixed by #23661
Labels
topic/accessibility This issue/pull request wants to improve the accessibility type/bug

Comments

@fsologureng
Copy link
Contributor

fsologureng commented Mar 22, 2023 •
edited
Loading

Description

With the PR 23526 the time tooltips began to be interactive, which means that the tippy module enable aria attributes as aria-expanded. However this attribute is invalid in the context of the actual estructure of the tooltip caller (the span container) which doesn't use labelledby to link the tooltip and haven't a role neither.

Description of tooltip role in MDN https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role
Description of tooltip role in current WAI-ARIA W3C Recommendation https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#tooltip

Gitea Version

1.19

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

tippy function
AxeCore DevTools critical issue

Git Version

No response

Operating System

No response

How are you running Gitea?

Locally and tested in https://try.gitea.io

Database

None
@jolheiser jolheiser added the topic/accessibility This issue/pull request wants to improve the accessibility label Mar 22, 2023
@silverwind
Copy link
Member

Tippy has some aria options, what should we set instead for such interactive tooltips?

fsologureng added a commit to fsologureng/gitea that referenced this issue Mar 23, 2023
@fsologureng
Add aria attributes to interactive time tooltips. Fixes go-gitea#23645.
a5c09d5
@fsologureng fsologureng mentioned this issue Mar 23, 2023
Merged
@fsologureng
Copy link
Contributor Author

Tippy has some aria options, what should we set instead for such interactive tooltips?

Thank you for your guidance to the manual 👍

lunny pushed a commit that referenced this issue Mar 24, 2023
@fsologureng
Add aria attributes to interactive time tooltips. (#23661)
87f0f7e 
Fixes #23645
* Added `describedby` attribute to the reference element.
* Eliminated `aria-expanded` attribute to the reference element in order
to conform strictly with WCAG 2.1 rules.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/accessibility This issue/pull request wants to improve the accessibility type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aria attributes to interactive time tooltips. fsologureng/gitea
3 participants
@silverwind @fsologureng @jolheiser