Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current main branch has a regression bug with bindata build #24002

Closed
wxiaoguang opened this issue Apr 8, 2023 · 0 comments · Fixed by #24003
Closed

Current main branch has a regression bug with bindata build #24002

wxiaoguang opened this issue Apr 8, 2023 · 0 comments · Fixed by #24003
Labels
type/bug

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 8, 2023 •
edited
Loading

Description

Caused by #23965 , bindata build can't find templates.

I am working on it.

Sorry for the inconvenience.

Gitea Version

dev

Can you reproduce the bug on the Gitea demo site?

Yes

How are you running Gitea?

bindata static build
@wxiaoguang wxiaoguang mentioned this issue Apr 8, 2023
Merged
lunny pushed a commit that referenced this issue Apr 8, 2023
@wxiaoguang
Make bindata static build parse builtin templates correctly (#24003)
94fde46 
Close #24002


Two problems before:

1. The `log.Fatal` is missing after these `wrapFatal` calls, so the
error is not shown to users.
2. `GetTemplateAssetNames` has different behaviors for local files and
builtin assets, for builtin assets, it also returns directories, so we
need to check the extension again.

I have tested with `TAGS="bindata sqlite sqlite_unlock_notify" make
build && ./gitea` , it works well now. Before, the server responds
internal server error (because it doesn't complete the template parsing)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make bindata static build parse builtin templates correctly wxiaoguang/gitea
1 participant
@wxiaoguang