Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push comments of pull request sometimes are missed. #24237

Closed
lunny opened this issue Apr 20, 2023 · 7 comments · Fixed by #24238
Closed

Push comments of pull request sometimes are missed. #24237

lunny opened this issue Apr 20, 2023 · 7 comments · Fixed by #24238
Labels
type/bug

Comments

@lunny
Copy link
Member

lunny commented Apr 20, 2023

Take a look at the PR https://gitea.com/gitea/blog/pulls/262 . There are 4 commits but no any commits comment on pull request conversation.
@lunny lunny added the type/bug label Apr 20, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 20, 2023 •
edited
Loading

Have you checked the database? I guess the problem is that when a PR is open, the comments are displayed. But for merged PRs, the commits are not displayed?

@wxiaoguang
Copy link
Contributor

A old PR https://gitea.com/gitea/blog/pulls/180 (2 years ago) doesn't show the commits either

@lunny
Copy link
Member Author

lunny commented Apr 20, 2023

Ah, really. But it's not GH style. I just noticed that.

@wxiaoguang
Copy link
Contributor

The code was written as this ....

	CommentTypePullRequestPush // 29 push to PR head branch

image

@wxiaoguang
Copy link
Contributor

I think there is a bug.

latestCloseCommentID is always 0

@lunny
Copy link
Member Author

lunny commented Apr 20, 2023

Caused by #23189 @sillyguodong

@wxiaoguang wxiaoguang mentioned this issue Apr 20, 2023
Merged
@wxiaoguang
Copy link
Contributor

Oh, I have proposed a fix

Show commit history for closed/merged PRs #24238

silverwind pushed a commit that referenced this issue Apr 21, 2023
@wxiaoguang @GiteaBot
Show commit history for closed/merged PRs (#24238)
13d1d27 
Close #24237

Before:

<details>


![image](https://user-images.githubusercontent.com/2114189/233424875-a69c6dad-df4a-483e-b796-36c6459af2d6.png)

</details>

After:


![image](https://user-images.githubusercontent.com/2114189/233424712-60a296de-017b-49a8-89b2-5925ff452646.png)

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this issue Apr 21, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Apr 21, 2023
@wxiaoguang @GiteaBot
Show commit history for closed/merged PRs (go-gitea#24238)
726c13c 
Close go-gitea#24237

Before:

<details>


![image](https://user-images.githubusercontent.com/2114189/233424875-a69c6dad-df4a-483e-b796-36c6459af2d6.png)

</details>

After:


![image](https://user-images.githubusercontent.com/2114189/233424712-60a296de-017b-49a8-89b2-5925ff452646.png)

Co-authored-by: Giteabot <[email protected]>
silverwind pushed a commit that referenced this issue Apr 21, 2023
@GiteaBot @wxiaoguang
Show commit history for closed/merged PRs (#24238) (#24261)
51fd730 
Backport #24238 by @wxiaoguang

Close #24237

Before:

<details>


![image](https://user-images.githubusercontent.com/2114189/233424875-a69c6dad-df4a-483e-b796-36c6459af2d6.png)

</details>

After:


![image](https://user-images.githubusercontent.com/2114189/233424712-60a296de-017b-49a8-89b2-5925ff452646.png)

Co-authored-by: wxiaoguang <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show commit history for closed/merged PRs wxiaoguang/gitea
2 participants
@lunny @wxiaoguang