Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitea Actions Log copies line numbers as well #24578

Closed
uvulpos opened this issue May 7, 2023 · 1 comment · Fixed by #24594
Closed

Gitea Actions Log copies line numbers as well #24578

uvulpos opened this issue May 7, 2023 · 1 comment · Fixed by #24594
Labels
topic/gitea-actions related to the actions of Gitea topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.20.0

Comments

@uvulpos
Copy link

uvulpos commented May 7, 2023

Description

I tried to copy my gitea actions log into a messager service and discovered that my selection copied also the line numbers. So I had to remove them by hands. Would be nice, if they were not selectable

Screenshots

Screenshot 2023-05-07 at 20 36 32

Gitea Version

1.19.x

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

MacOS

Browser Version

Waterfox G5.1.5
@uvulpos uvulpos added type/bug topic/ui Change the appearance of the Gitea UI labels May 7, 2023
@lunny lunny added the topic/gitea-actions related to the actions of Gitea label May 8, 2023
@wxiaoguang
Copy link
Contributor

I guess adding a user-select: none is good enough

@yardenshoham yardenshoham mentioned this issue May 8, 2023
Merged
silverwind pushed a commit that referenced this issue May 8, 2023
@yardenshoham
Do not select line numbers when selecting text from the action run lo…
9ad5b59 
…gs (#24594)

- Fixes #24578

# Before

![image](https://user-images.githubusercontent.com/20454870/236873942-26e97f28-6595-4be9-88fa-158870eda253.png)

# After

![image](https://user-images.githubusercontent.com/20454870/236874171-8f0182a5-e953-4740-b875-f3542dee8325.png)

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot mentioned this issue May 8, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 8, 2023
@yardenshoham @GiteaBot
Do not select line numbers when selecting text from the action run lo…
36a8811 
…gs (go-gitea#24594)

- Fixes go-gitea#24578

# Before

![image](https://user-images.githubusercontent.com/20454870/236873942-26e97f28-6595-4be9-88fa-158870eda253.png)

# After

![image](https://user-images.githubusercontent.com/20454870/236874171-8f0182a5-e953-4740-b875-f3542dee8325.png)

Signed-off-by: Yarden Shoham <[email protected]>
silverwind pushed a commit that referenced this issue May 8, 2023
@GiteaBot @yardenshoham
Do not select line numbers when selecting text from the action run lo…
7eaf7aa 
…gs (#24594) (#24596)

Backport #24594 by @yardenshoham

- Fixes #24578

# Before

![image](https://user-images.githubusercontent.com/20454870/236873942-26e97f28-6595-4be9-88fa-158870eda253.png)

# After

![image](https://user-images.githubusercontent.com/20454870/236874171-8f0182a5-e953-4740-b875-f3542dee8325.png)

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
@delvh delvh added this to the 1.20.0 milestone May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/gitea-actions related to the actions of Gitea topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Do not select line numbers when selecting text from the action run logs yardenshoham/gitea
4 participants
@lunny @wxiaoguang @delvh @uvulpos