Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Summary] Improvements on actions run/job detail page #24625

Closed
HesterG opened this issue May 10, 2023 · 9 comments · Fixed by #24718
Closed

[Summary] Improvements on actions run/job detail page #24625

HesterG opened this issue May 10, 2023 · 9 comments · Fixed by #24718
Assignees
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first. type/summary This issue aggregates a bunch of other issues

Comments

@HesterG
Copy link
Contributor

HesterG commented May 10, 2023

Feature Description

Screen Shot 2023-05-09 at 17 07 50

For this page, some improvements on ui can be made:

  1. For the left panel, it is better to show rerun icon only on hover, and add style when the job is selected

    Untitled.mov
  2. Move the rerun workflow icon to a consistent position. Probably move it to top right corner as a button, or add a management section under left panel

    Screen Shot 2023-05-10 at 09 55 50

    Possible option 1: Top right corner
    Screen Shot 2023-05-09 at 17 25 53

    Possible option 2: Add management section on left panel
    Screen Shot 2023-05-10 at 12 01 53

  3. Adjust fonts (maybe generally smaller and use some secondary colors so the page will look more spatial), and add on hover effects to the log lines. And add loading effect when exanpanding the log.

    On hover effect:

    Screen Shot 2023-05-09 at 17 35 49

    Loading when expanding log lines:

    Untitled.mov
  4. Add some left/right padding to the action-view-container

  5. Add gt-ellipsis to summary lines

    Screen Shot 2023-05-11 at 16 30 56

Screenshots

No response

@HesterG HesterG added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI type/summary This issue aggregates a bunch of other issues and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels May 10, 2023
@wolfogre
Copy link
Member

Some work has been done at #24611

@wolfogre
Copy link
Member

One more thing, when loading the page, you will see an instant failure icon.

Screen.Recording.2023-05-10.at.13.37.21.mov

@HesterG HesterG self-assigned this May 10, 2023
@silverwind
Copy link
Member

silverwind commented May 10, 2023

One more thing, when loading the page, you will see an instant failure icon.

Backend should render this initially on page load if possible, JS can then afterwards take over for dynamic updates.

Adjust fonts (maybe generally smaller and use some secondary colors so the page will look more spatial)

For the "console box": Maybe tone down the bold in the fonts and use a less contrasting text color. I think we should consider not using the super contrastful console colors. I would also consider actually making the console window have a light background on light theme. This black box just looks out of place in a light theme to me.

@HesterG
Copy link
Contributor Author

HesterG commented May 11, 2023

One more thing, when loading the page, you will see an instant failure icon.

Backend should render this initially on page load if possible, JS can then afterwards take over for dynamic updates.

I think this is because ActionRunStatus renders failure icon by default, should adjust that condition to only accept explicit action status.

@HesterG
Copy link
Contributor Author

HesterG commented May 11, 2023

For the "console box": Maybe tone down the bold in the fonts and use a less contrasting text color. I think we should consider not using the super contrastful console colors.

I will try to use secondary colors as they are grey and should make less contrast.

I would also consider actually making the console window have a light background on light theme. This black box just looks out of place in a light theme to me.

I am pretty bad at managing color themes, might need some help with this..

@silverwind
Copy link
Member

I can probably check out the console box colors later.

Do people generally agree that white background on light theme is fine?

@wolfogre
Copy link
Member

Do people generally agree that white background on light theme is fine?

I would say I would agree only if I see the demo and it looks good. Because the console box is always black on Drone CI or GitHub Actions even if the theme is light. That's not a strong reason, just a stereotype.

Details image image

@silverwind
Copy link
Member

I think it goes against the theme's design to put a box of the opposing color scheme into the interface. In the past, many terminals where black, but today it's very much possible to run a light terminal as well and many do.

@lunny
Copy link
Member

lunny commented May 11, 2023

I never used a white background terminal...

lunny pushed a commit that referenced this issue May 22, 2023
Close #24625 

Main changes:

1. For the left panel, show rerun icon only on hover, and add style when
the job is selected, and removed icon on the "rerun all" button and
modify the text on the button


https://github.com/go-gitea/gitea/assets/17645053/cc437a17-d2e9-4f1b-a8cf-f56e53962767

2. Adjust fonts, and add on hover effects to the log lines. And add
loading effect when the job is done and the job step log is expanded for
the first time. (With reference to github)


https://github.com/go-gitea/gitea/assets/17645053/2808d77d-f402-4fb0-8819-7aa0a018cf0c

3. Add `gt-ellipsis` to `step-summary-msg` and `job-brief-name`

<img width="898" alt="ellipsis"
src="https://github.com/go-gitea/gitea/assets/17645053/e2fb7049-3125-4252-970d-15b0751febc7">

4. Fixed
#24625 (comment)
by adding explicit conditions to `ActionRunStatus.vue` and `status.tmpl`

5. Adjust some css styles

---------

Co-authored-by: silverwind <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first. type/summary This issue aggregates a bunch of other issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants