-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Summary] Improvements on actions run/job detail page #24625
Comments
Some work has been done at #24611 |
One more thing, when loading the page, you will see an instant failure icon. Screen.Recording.2023-05-10.at.13.37.21.mov |
Backend should render this initially on page load if possible, JS can then afterwards take over for dynamic updates.
For the "console box": Maybe tone down the bold in the fonts and use a less contrasting text color. I think we should consider not using the super contrastful console colors. I would also consider actually making the console window have a light background on light theme. This black box just looks out of place in a light theme to me. |
I think this is because |
I will try to use secondary colors as they are grey and should make less contrast.
I am pretty bad at managing color themes, might need some help with this.. |
I can probably check out the console box colors later. Do people generally agree that white background on light theme is fine? |
I think it goes against the theme's design to put a box of the opposing color scheme into the interface. In the past, many terminals where black, but today it's very much possible to run a light terminal as well and many do. |
I never used a white background terminal... |
# Before ![rec](https://github.com/go-gitea/gitea/assets/20454870/32f8e521-f743-4101-bd3c-923fd5abd893) # After ![rec](https://github.com/go-gitea/gitea/assets/20454870/070721d1-6749-43c1-ac18-d8c58e5f0901) Ref: #24625 Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: Giteabot <[email protected]>
Close #24625 Main changes: 1. For the left panel, show rerun icon only on hover, and add style when the job is selected, and removed icon on the "rerun all" button and modify the text on the button https://github.com/go-gitea/gitea/assets/17645053/cc437a17-d2e9-4f1b-a8cf-f56e53962767 2. Adjust fonts, and add on hover effects to the log lines. And add loading effect when the job is done and the job step log is expanded for the first time. (With reference to github) https://github.com/go-gitea/gitea/assets/17645053/2808d77d-f402-4fb0-8819-7aa0a018cf0c 3. Add `gt-ellipsis` to `step-summary-msg` and `job-brief-name` <img width="898" alt="ellipsis" src="https://github.com/go-gitea/gitea/assets/17645053/e2fb7049-3125-4252-970d-15b0751febc7"> 4. Fixed #24625 (comment) by adding explicit conditions to `ActionRunStatus.vue` and `status.tmpl` 5. Adjust some css styles --------- Co-authored-by: silverwind <[email protected]>
Feature Description
For this page, some improvements on ui can be made:
For the left panel, it is better to show rerun icon only on hover, and add style when the job is selected
Untitled.mov
Move the rerun workflow icon to a consistent position. Probably move it to top right corner as a button, or add a management section under left panel
Possible option 1: Top right corner
Possible option 2: Add management section on left panel
Adjust fonts (maybe generally smaller and use some secondary colors so the page will look more spatial), and add on hover effects to the log lines. And add loading effect when exanpanding the log.
On hover effect:
Loading when expanding log lines:
Untitled.mov
Add some left/right padding to the
action-view-container
Add
gt-ellipsis
to summary linesScreenshots
No response
The text was updated successfully, but these errors were encountered: