Navbar width horizontal overflow in 1.20rc #25221
Comments
|
It's not related to navbar. IMO actually is a regression of #21850 You can see I have remove the "navbar" and "footer", only "page-content" there:
|
|
@wxiaoguang Actually the scrollbar will invisble if I remove navbar element
|
But it is there in my screenshot, have you tried different pages and different sizes? In some cases "removing navbar element" makes the scrollbar invisible, but in some cases the UI is still not right. That's why I do not think the navbar is the root problem, while there is something wrong behind it. |
|
Can you try this one? Revert overflow: overlay (revert |
Looks effective! This revert may cover more case in the UI. |
|
@wxiaoguang But this revert will just hide horizontal scrollbar(because it's not overlay yet).
|
|
See #25231 (comment) |
It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. --------- Co-authored-by: Giteabot <[email protected]> Co-authored-by: silverwind <[email protected]>
It causes not only one issue like go-gitea#25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (go-gitea#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. --------- Co-authored-by: Giteabot <[email protected]> Co-authored-by: silverwind <[email protected]>
Backport #25231 by @wxiaoguang It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: silverwind <[email protected]>
Description
Hi all,
I find Gitea UI showing horizontal scrollbar when the content is more than screen like screen shot case. Look like the navbar has overflow its container.
It can be found in try.gitea.io at: https://try.gitea.io/explore/repos
Actually I never found this issue under 1.20-rc.
Maybe the problem is similar with this post, and we can add
max-width: 100%oroverflow-x: hiddento solve it.Screenshots
Gitea Version
1.20.0+rc0-17-g3e9fc3672
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
MacOS Ventura & Windows 11
Browser Version
Microsoft Edge 114.0.1823.37
The text was updated successfully, but these errors were encountered: