Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-sense "You pushed on branch ...." notification #25778

Closed
1 of 2 tasks
wxiaoguang opened this issue Jul 9, 2023 · 5 comments · Fixed by #25795
Closed
1 of 2 tasks

Non-sense "You pushed on branch ...." notification #25778

wxiaoguang opened this issue Jul 9, 2023 · 5 comments · Fixed by #25795
Assignees
@dsseng
Labels
type/bug
Milestone
1.21.0

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 9, 2023 •
edited
Loading

Description

Reproduce step:

  1. Create a branch
  2. Create a PR
  3. Merge the PR
  4. Go to the repo home

Now, these 2 notifications are non-sense.

  • For "main" branch: yes, it is changed.
  • For "root-patch-1": it has been merged.

image

Gitea Version

1.21
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jul 9, 2023
@silverwind
Copy link
Member

Default branch should never notify imho.

@hiifong
Copy link
Contributor

hiifong commented Jul 9, 2023

Default branch should never notify imho.

agree

@dsseng
Copy link
Contributor

dsseng commented Jul 9, 2023

I want to work on this. If I won't submit a fix within a week, consider the task free again

@lunny lunny mentioned this issue Jul 10, 2023
Merged
@lunny lunny mentioned this issue Jul 10, 2023
Closed
@dsseng dsseng mentioned this issue Jul 10, 2023
Closed
silverwind pushed a commit that referenced this issue Jul 10, 2023
@lunny @GiteaBot
Exclude default branch from pushed branch hint (#25795)
2f31d2d 
When pushing to default branch, no pushing hint should be prompt.
Fix #25778

---------

Co-authored-by: Giteabot <[email protected]>
@wxiaoguang wxiaoguang reopened this Jul 10, 2023
@dsseng
Copy link
Contributor

dsseng commented Jul 10, 2023

Oops, apparently lunny also took this, but only made it ignore default branch. My PR does also exclude branches with merged PRs. Let me rebase it

dsseng added a commit to dsseng/gitea that referenced this issue Jul 11, 2023
@dsseng @yp05327
Hide push notifications from merged branches
ce249c5 
Fixes go-gitea#25778

Co-authored-by: yp05327 <[email protected]>
@wxiaoguang
Copy link
Contributor Author

Close because I am not tracking this problem, maybe some have been fixed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dsseng dsseng

Labels
type/bug
Projects
None yet
Milestone
1.21.0
4 participants
@silverwind @wxiaoguang @dsseng @hiifong