Release is not Updated when recreating Tag

[JakobDev]

Description

If you recreate a Tag on a new Commit, the Release will not be updated.

Steps to reproduce:

1. Create a new Repo
2. Create a new Release with a Tag called "Test"
3. Clone the Repo
4. Run these commands:

git tag -d Test
git commit --allow-empty -m "New Commit"
git tag Test
git push
git push -f --tags

If you visit the Release Page, it shows

1 commits to main since this release

But this is not true. The Tag has now changed to the latest Commit.

I expect Gitea to do one of these 2 Options:

1. Just Update the Release
2. Do the same as if the Tag was deleted

Gitea Version

1.20.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

Not relevant to reproduce

Screenshots

No response

Git Version

2.41.0

Operating System

Manjaro

How are you running Gitea?

Binary downloaded from GitHub

Database

SQLite

[CaiCandong]

I can't reproduce your problem on gitea, I'm getting everything fine, Release is being updated automatically.
https://gitea.com/caicandong/gitea-debug

[JakobDev]

What have you done? Delete Tag > Push > Recreate Tag > Push or Delete Tag > Recreate Tag > Push?

[CaiCandong]

What have you done? Delete Tag > Push > Recreate Tag > Push or Delete Tag > Recreate Tag > Push?

Follow your reproduction steps

[CaiCandong]

@JakobDev I recorded a video that you can watch.

default.mp4

[JakobDev]

Interesting. Did you try this on 1.20.1 or the latest commit?

[CaiCandong]

Interesting. Did you try this on 1.20.1 or the latest commit?

My code is based on the latest commit

[Zettat123]

@JakobDev I recorded a video that you can watch.

default.mp4

That's weird. I followed the steps in this video and finally reproduced the bug

[wolfogre]

The point is that the tag Test has an uppercase letter, and the incorrect code attempted to find existing releases with a lower name but couldn't find it. Then, when it tried to create a new one, it failed due to a unique index constraint. Therefore, you should see this error log:

2024/02/19 16:15:45 ...s/repository/push.go:41:handler() [E] pushUpdate[root/update_tag_release] failed: PushUpdateAddDeleteTags: Insert: pq: duplicate key value violates unique constraint "UQE_release_n"

And why can't CaiCandong reproduce, while Zettat123 can? I think CaiCandong is using a database that is case-insensitive, maybe MySQL with a case-insensitive collation.

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines