Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button in file commit history to view file at commit #26707

Closed
silverwind opened this issue Aug 24, 2023 · 1 comment · Fixed by #27354
Closed

Button in file commit history to view file at commit #26707

silverwind opened this issue Aug 24, 2023 · 1 comment · Fixed by #27354
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

silverwind commented Aug 24, 2023 •
edited
Loading

Feature Description

When viewing a file's commit history, GitHub has a button to view a file at a specific commit, for example:

https://github.com/go-gitea/gitea/commits/main/README.md

Screenshot 2023-08-24 at 11 46 33

It should be easy to add, just check whether the commit log is for a file, and if so, construct a link to file with the commit hash.

Possibly depends on #24423.
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Aug 24, 2023
@yardenshoham yardenshoham added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Aug 25, 2023
@silverwind
Copy link
Member Author

Also related, when viewing the root commit history, also show this button:

image

@silverwind silverwind mentioned this issue Sep 29, 2023
Merged
techknowlogick pushed a commit that referenced this issue Oct 2, 2023
@denyskon @silverwind
link to file from its history (#27354)
33de64c 
Fixes #3852
Fixes #26707

Add a button on file history which directs you to the file at the
selected commit.

Co-authored-by: silverwind <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

link to file from its history denyskon/gitea
2 participants
@silverwind @yardenshoham