Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommentTypeDismissReview are not deleted when deleting a Review #27767

Closed
jpraet opened this issue Oct 24, 2023 · 0 comments · Fixed by #27903
Closed

CommentTypeDismissReview are not deleted when deleting a Review #27767

jpraet opened this issue Oct 24, 2023 · 0 comments · Fixed by #27903
Labels
type/bug
Milestone
1.20.6

Comments

@jpraet
Copy link
Member

jpraet commented Oct 24, 2023

Description

Now that some error logging has been added in 1.20.5, I have been able to find the root cause of #27306:

When deleting a review, comments of type CommentTypeDismissReview are not deleted.

Gitea Version

1.20.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL
@lunny lunny added this to the 1.20.6 milestone Oct 24, 2023
@lng2020 lng2020 mentioned this issue Nov 4, 2023
Merged
silverwind pushed a commit that referenced this issue Nov 5, 2023
@lng2020
Fix 500 when deleting a dismissed review (#27903)
966dcb9 
Fix #27767 
Add a test to ensure its behavior
@GiteaBot GiteaBot mentioned this issue Nov 5, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 5, 2023
@lng2020 @GiteaBot
Fix 500 when deleting a dismissed review (go-gitea#27903)
ff3929b 
Fix go-gitea#27767 
Add a test to ensure its behavior
silverwind pushed a commit that referenced this issue Nov 5, 2023
@GiteaBot @lng2020
Fix 500 when deleting a dismissed review (#27903) (#27910)
61d3d92 
Backport #27903 by @lng2020

Fix #27767 
Add a test to ensure its behavior

Co-authored-by: Nanguan Lin <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@lng2020 @fuxiaohei
Fix 500 when deleting a dismissed review (go-gitea#27903)
d312d8a 
Fix go-gitea#27767 
Add a test to ensure its behavior
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@lng2020 @silverwind
Fix 500 when deleting a dismissed review (go-gitea#27903)
8c6bcba 
Fix go-gitea#27767 
Add a test to ensure its behavior
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.6
Development

Successfully merging a pull request may close this issue.

Fix 500 when deleting a dismissed review lng2020/gitea
2 participants
@lunny @jpraet