Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors page doesn't look good on mobile view #29192

Closed
sahinakkaya opened this issue Feb 16, 2024 · 6 comments · Fixed by #29597
Closed

Contributors page doesn't look good on mobile view #29192

sahinakkaya opened this issue Feb 16, 2024 · 6 comments · Fixed by #29597
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.0

Comments

@sahinakkaya
Copy link
Contributor

sahinakkaya commented Feb 16, 2024 •
edited
Loading

Description

Contributors page doesn't look good on mobile view.

See it here: https://try.gitea.io/kamiya/Xray-core/activity/contributors

Screenshots

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Browser Version
@sahinakkaya sahinakkaya added topic/ui Change the appearance of the Gitea UI type/bug labels Feb 16, 2024
@silverwind
Copy link
Member

silverwind commented Feb 16, 2024 •
edited
Loading

Hmm, I thought we had media query that makes these single-column on mobile, should re-verify. And I think we can reduce chart height a bit, even on desktop so that more fit on a mobile page.

@sahinakkaya
Copy link
Contributor Author

The title showing date range is also too big. I think it should fit on a single line.

@sahinakkaya
Copy link
Contributor Author

And also the dropdown menu on the right of the title.

@silverwind
Copy link
Member

silverwind commented Feb 16, 2024 •
edited
Loading

Dropdown text can be reduced to Commits, Font size on title maybe slightly reduced.

@lunny lunny added this to the 1.22.0 milestone Feb 19, 2024
@silverwind silverwind added the good first issue Likely to be an easy fix label Feb 22, 2024
@yp05327
Copy link
Contributor

yp05327 commented Feb 27, 2024

related: #27882 (comment)

silverwind added a commit to silverwind/gitea that referenced this issue Mar 4, 2024
@silverwind
Fix contributor grid responsiveness
e9e421b 
Also removed a unneeded and actually conflicting class name.

Fixes: go-gitea#29192
@silverwind silverwind mentioned this issue Mar 4, 2024
Merged
@silverwind
Copy link
Member

#29597

@silverwind silverwind removed the good first issue Likely to be an easy fix label Mar 4, 2024
silverwind added a commit that referenced this issue Mar 5, 2024
@silverwind
Fix contributor graphs mobile layout and responsiveness (#29597)
f147795 
Also removed a unneeded and actually conflicting class name
`stats-table`.

Fixes: #29192

<img width="445" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/787804ed-6ba4-437f-b314-f23cbe2edf7a">
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 13, 2024
@silverwind @earl-warren
Fix contributor graphs mobile layout and responsiveness (#29597)
02384ff 
Also removed a unneeded and actually conflicting class name
`stats-table`.

Fixes: go-gitea/gitea#29192

<img width="445" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/787804ed-6ba4-437f-b314-f23cbe2edf7a">

(cherry picked from commit f14779592494d41b3ab04caaab53487f2f4ede5a)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fix contributor graphs mobile layout and responsiveness silverwind/gitea
4 participants
@lunny @silverwind @yp05327 @sahinakkaya