Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: POST releases/{id}/assets should accept application/octet-stream #29502

Closed
silverwind opened this issue Feb 29, 2024 · 1 comment · Fixed by #29507
Closed

API: POST releases/{id}/assets should accept application/octet-stream #29502

silverwind opened this issue Feb 29, 2024 · 1 comment · Fixed by #29507
Assignees
@KN4CK3R
Labels
topic/api Concerns mainly the API topic/gitea-actions related to the actions of Gitea

Comments

@silverwind
Copy link
Member

silverwind commented Feb 29, 2024 •
edited
Loading

Feature Description

Adding release assets on GitHub's API accepts application/octet-stream while Gitea's API accepts multipart/form-data.

It should be made to accept both which is necessary for actions like ncipollo/release-action to work.
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. modifies/api This PR adds API routes or modifies them topic/gitea-actions related to the actions of Gitea topic/repo Related to repositories and removed modifies/api This PR adds API routes or modifies them labels Feb 29, 2024
@KN4CK3R KN4CK3R self-assigned this Feb 29, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 29, 2024

Strange that this essential endpoint is not Github compatible.

@KN4CK3R KN4CK3R mentioned this issue Feb 29, 2024
Merged
@silverwind silverwind added topic/api Concerns mainly the API and removed topic/repo Related to repositories type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 1, 2024
silverwind pushed a commit that referenced this issue Mar 2, 2024
@KN4CK3R @GiteaBot
Add support for API blob upload of release attachments (#29507)
70c126e 
Fixes #29502

Our endpoint is not Github compatible.


https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset

---------

Co-authored-by: Giteabot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KN4CK3R KN4CK3R

Labels
topic/api Concerns mainly the API topic/gitea-actions related to the actions of Gitea
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for API blob upload of release attachments KN4CK3R/gitea
2 participants
@silverwind @KN4CK3R