Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits in the dashboard don't show signatures #29858

Closed
b1ek opened this issue Mar 17, 2024 · 2 comments
Closed

Commits in the dashboard don't show signatures #29858

b1ek opened this issue Mar 17, 2024 · 2 comments
Labels
issue/duplicate The issue has already been reported. topic/ui Change the appearance of the Gitea UI type/bug

Comments

@b1ek
Copy link

b1ek commented Mar 17, 2024

Description

If a commit is signed, it will not be shown as signed in the dashboard.

Steps to reproduce:

  1. Add a GPG key to your account if it is not added already
  2. Push a signed commit to a repository
  3. It won't be shown as signed in the dashboard

Screenshots

As you can see on this screenshot, the commit is shown as unsigned:

a screenshot of a dashboard that shows that commit is unsigned

But it is actually signed

a screenshot with full commit details, where it clearly says that the commit is signed

I have expected it to show like it is shown in the commit history (with the green badge):

a screenshot of the commit history that shows a green badge with a lock symbol signaling that the commit is signed

Gitea Version

I am running the docker tag "gitea/gitea:1.21.3": 1.21.3 built with GNU Make 4.4.1, go1.21.5 : bindata, timetzdata, sqlite, sqlite_unlock_notify. The server's linux version is 6.4.12-arch1-1

Can you reproduce the bug on the Gitea demo site?

I can, but I don't want to. The issue is pretty straightforward and can be confirmed by any gitea user that signs their commits

Operating System

I am running Arch on linux 6.7.9-arch-1 x86

Browser Version

I use Firefox Nightly, however it is not a browser specific issue since it doesnt have the CSS classes for that

image
image

@b1ek b1ek added topic/ui Change the appearance of the Gitea UI type/bug labels Mar 17, 2024
@silverwind
Copy link
Member

While the issue is accurate, I don't think we should do it there as per #29641.

@yp05327
Copy link
Contributor

yp05327 commented Mar 22, 2024

duplicate #28281

@lunny lunny closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@lunny lunny added the issue/duplicate The issue has already been reported. label Mar 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

4 participants