Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate commit verification in commit feeds #28281

Closed
hazycora opened this issue Nov 29, 2023 · 1 comment
Closed

Indicate commit verification in commit feeds #28281

hazycora opened this issue Nov 29, 2023 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@hazycora
Copy link
Contributor

Feature Description

Since the commit UI in feeds has been brought closer to how they are elsewhere since #27356, I think it would make sense to indicate verification here like is the case everywhere else.

The background colour to the commit hashes makes it look like my commits aren't verified. After updating to the latest release, I forgot that commit hashes didn't previously have a background colour indicating verification and thought something had broken with my signatures!

I'm not sure if this is something that can easily be changed, I don't know if the commit structs being used in the template there have their Verification defined. If this is something that could be done, please consider it! :3

Screenshots

Currently:
image
Instead it should indicate the commits are signed like everywhere else in the app
image

@hazycora hazycora added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 29, 2023
@silverwind
Copy link
Member

With #29641, the plan is to remove these signature indicators in the hash, so all hashes render the same everywhere, so I think I will reject this.

@silverwind silverwind closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants