Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFS Lock list should display lock owner instead of repository owner #31784

Closed
NateScarlet opened this issue Aug 6, 2024 · 1 comment · Fixed by #31788
Closed

LFS Lock list should display lock owner instead of repository owner #31784

NateScarlet opened this issue Aug 6, 2024 · 1 comment · Fixed by #31788
Assignees
@wolfogre
Labels
good first issue Likely to be an easy fix issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@NateScarlet
Copy link
Contributor

Description

$.Owner here seems to be repository owner instead of LFS Lock owner

gitea/templates/repo/settings/lfs_locks.tmpl

Lines 33 to 36 in 94cca88

<a href="{{$.Owner.HomeLink}}">
{{ctx.AvatarUtils.Avatar $.Owner}}
{{$.Owner.DisplayName}}
</a>

can not reproduce on demo site, because lfs not enabled

Screenshots

image

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

No

Operating System

win11 22H2

Browser Version

chrome 127
@NateScarlet NateScarlet added topic/ui Change the appearance of the Gitea UI type/bug labels Aug 6, 2024
@techknowlogick techknowlogick added type/proposal The new feature has not been accepted yet but needs to be discussed first. good first issue Likely to be an easy fix labels Aug 6, 2024
@wolfogre
Copy link
Member

wolfogre commented Aug 7, 2024

Confirmed. I'm going to fix it if no one is working on this.

@wolfogre wolfogre added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 7, 2024
@wolfogre wolfogre self-assigned this Aug 7, 2024
@wolfogre wolfogre mentioned this issue Aug 7, 2024
Merged
wolfogre added a commit that referenced this issue Aug 11, 2024
@wolfogre
Show lock owner instead of repo owner on LFS setting page (#31788)
0470646 
Fix #31784.

Before:

<img width="1648" alt="image"
src="https://github.com/user-attachments/assets/03f32545-4a85-42ed-bafc-2b193a5d8023">

After:

<img width="1653" alt="image"
src="https://github.com/user-attachments/assets/e5bcaf93-49cb-421f-aac1-5122bc488b02">
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Aug 11, 2024
@wolfogre @GiteaBot
Show lock owner instead of repo owner on LFS setting page (go-gitea#3…
6076ffd 
…1788)

Fix go-gitea#31784.

Before:

<img width="1648" alt="image"
src="https://github.com/user-attachments/assets/03f32545-4a85-42ed-bafc-2b193a5d8023">

After:

<img width="1653" alt="image"
src="https://github.com/user-attachments/assets/e5bcaf93-49cb-421f-aac1-5122bc488b02">
@GiteaBot GiteaBot mentioned this issue Aug 11, 2024
Merged
lafriks pushed a commit that referenced this issue Aug 11, 2024
@GiteaBot @wolfogre
Show lock owner instead of repo owner on LFS setting page (#31788) (#…
a39fe53 
…31817)

Backport #31788 by @wolfogre

Fix #31784.

Before:

<img width="1648" alt="image"
src="https://github.com/user-attachments/assets/03f32545-4a85-42ed-bafc-2b193a5d8023">

After:

<img width="1653" alt="image"
src="https://github.com/user-attachments/assets/e5bcaf93-49cb-421f-aac1-5122bc488b02">

Co-authored-by: Jason Song <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wolfogre wolfogre

Labels
good first issue Likely to be an easy fix issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show lock owner instead of repo owner on LFS setting page wolfogre/gitea
3 participants
@techknowlogick @wolfogre @NateScarlet