PANIC: index out of range when viewing org file in repository

[howdoicomputer]

• Gitea version (or commit ref): 1.5.1
• Git version: 2.14.1
• Operating system: Ubuntu 17.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://try.gitea.io/howdoicomputer/org-test
  • No
  • Not relevant
• Log gist: https://gist.github.com/howdoicomputer/4b85078aea5750c042bd7b9292d7f65f

Description

I checked in an org file to a private repository. I'm able to pull the file and view the diff but rendering it in the web view produces a blank page and stack trace.

[howdoicomputer]

It looks like Gitea fails to render if goorgeous fails to parse. I pushed a simpler test.org file and it rendered fine.

[howdoicomputer]

This is an upstream issue: curiouslychase/_goorgeous#82

Goorgeous cannot parse org files with empty headerlines.

[zeripath]

Ok, although the original cause of this bug is in an upstream library - now that we know about it we should recover from panics within that library and just render the text with an error.

See https://blog.golang.org/defer-panic-and-recover

We should also have a root handler for Macaron that does a similar recover and returns a gitea 500. Probably with two different levels of information depending on the production mode. (I.e. report stack trace or not)

[adelowo]

@zeripath There is already a handler for recovery. I believe the application should keep on
running. I have run into a few waves of panic too

gitea/routers/routes/routes.go

Line 55 in a967cf9

m.Use(macaron.Recovery())

https://github.com/go-macaron/docs/blob/master/en-US/middlewares/core_services.md

[zeripath]

Ah but that is not good enough - the user gets a blank page.

[igor9292]

colleagues, and you can make the file appear just text,
file was displayed without formatting?

[zeripath]

I'm removing the status/blocked label. Yes we can't prevent goorgeous from having a panic but we can damned well stop that propogating - and we should. I've put a PR up to recover from the panic and just return the original byte array as plain text. This is the simplest thing to do but is perhaps a little unfriendly - another solution might be to return "Unable to render" instead.

[howdoicomputer]

There is also this open issue that suggests replacing goorgeous with another library.

#5710