Tags with % cause an error #6321
Comments
|
Paging @mrsdizzie - this is another example of bad escaping. |
|
This would have at least two separate causes. Not being able to add via the Web interface is because of bad logic here: gitea/modules/validation/binding.go Lines 21 to 22 in 22d3d02 On the command line, I was able to successfully push a tag with the same name as the example above: https://try.gitea.io/mrsdizzie/parsing-errors/releases Are you able to replicate not being able to push tags on the command line with try.gitea.org? If so, can you let me know the exact commands for creating and pushing since I wasn't able to reproduce that part just using the name above. I'll start working on a PR for the other part (and this should get a bug tag) |
Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321
|
I agree, pushing the branch does work in try.gitea.io. Moreover, I've
also verified that it works locally using gitea master. I re-confirmed
that it did not work in 1.7.4, and a little digging suggests that
@zeripath fixed that in #6304 two days before I reported the bug.
Perhaps I was sloppy in testing. I'm sorry for the confusion.
At any rate, it looks like that half of the problem is solved and the
only issue remaining is the web validation.
Thanks!
|
|
Ah OK great, glad that also works for you. The PR I just made will fix the web validation side pending review/approval. |
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of #6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
|
This can be closed per d056bf3 |
Description
Git supports "%" in ref names, but Gitea rejects them. In the web UI, creating a tag with the name "debian/1%1.6.0-2" produces the error "TagName must be a well-formed Git reference name." When attempting to push the same tag to a repo, the following error appears:
We can confirm that git supports a ref with "%" by either creating a tag with git or running:
Screenshots
https://screenshots.firefox.com/u1vElZ2A4wLQeXIk/try.gitea.io
The text was updated successfully, but these errors were encountered: