Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on changing user and organization name #9531

Closed
kasbah opened this issue Dec 28, 2019 · 4 comments · Fixed by #11649
Closed

Redirect on changing user and organization name #9531

kasbah opened this issue Dec 28, 2019 · 4 comments · Fixed by #11649
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kasbah
Copy link

kasbah commented Dec 28, 2019

Currently gitea redirects repository URLs when you change the repository name (implemented in #807), but if you change a username or organization name then gitea won't redirect.

I am just wondering if there is interest in having redirects on username and organization name change implemented as well.

@lafriks
Copy link
Member

lafriks commented Dec 29, 2019

That is tricky one as somebody can create org or user with old name so it would not be consistent and could lead to potential problems

@kasbah
Copy link
Author

kasbah commented Dec 29, 2019

There is a similar problem for just changing repository names that was already solved in #807 I believe. The solution is to not redirect when a new org/user takes the old name. This is also how Github does it.

If the new owner of your old username creates a repository with the same name as your repository, that will override the redirect entry and your redirect will stop working.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 1, 2020
@lunny
Copy link
Member

lunny commented Jan 1, 2020

@lafriks What's the problems? But we have implemented the redirects when you change repository name.

@lafriks
Copy link
Member

lafriks commented Jan 1, 2020

No problem, could be some risks but I'm fine if someone sends PR for this

6543 added a commit to AndrewBezold/gitea that referenced this issue Jan 23, 2021
6543 added a commit to AndrewBezold/gitea that referenced this issue Jan 23, 2021
6543 added a commit to AndrewBezold/gitea that referenced this issue Jan 24, 2021
6543 added a commit to AndrewBezold/gitea that referenced this issue Jan 24, 2021
lunny added a commit to AndrewBezold/gitea that referenced this issue Jan 24, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants