Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More expansions in template repositories #10021

Merged
merged 8 commits into from
Jan 28, 2020

Conversation

jolheiser
Copy link
Member

Also fixes a regression from #9489 where there is a nil error.
It was not backported (and is correct in 1.11)

This PR adds some extra options for expansions in template repositories.
As well, I decided to move the docs into its own since it's already the entire page.

Adds a new module xstrings (MIT) to avoid maintaining edge-cases for string conversions to various -case
xstrings is actually the repo that com takes its ToSnakeCase func from anyways.

@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #10021 into master will increase coverage by <.01%.
The diff coverage is 59.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10021      +/-   ##
==========================================
+ Coverage   42.26%   42.26%   +<.01%     
==========================================
  Files         610      611       +1     
  Lines       80389    80396       +7     
==========================================
+ Hits        33974    33977       +3     
- Misses      42235    42240       +5     
+ Partials     4180     4179       -1
Impacted Files Coverage Δ
services/pull/review.go 0% <0%> (ø) ⬆️
routers/repo/commit.go 29.66% <0%> (ø) ⬆️
modules/migrations/gitea.go 6.14% <0%> (-0.02%) ⬇️
services/gitdiff/gitdiff.go 67.62% <100%> (+1.36%) ⬆️
models/pull.go 43.24% <100%> (+0.33%) ⬆️
modules/git/diff.go 62.03% <62.03%> (ø)
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
modules/queue/workerpool.go 39.91% <0%> (-1.29%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2972a34...7653c1f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2020
@zeripath zeripath added type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 27, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2020
Signed-off-by: jolheiser <[email protected]>
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 28216bd into go-gitea:master Jan 28, 2020
@jolheiser jolheiser mentioned this pull request Jan 29, 2020
15 tasks
@jolheiser jolheiser deleted the template_expansion branch January 30, 2020 19:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants