Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/fields/terms #1031

Merged
merged 1 commit into from
Feb 24, 2017
Merged

s/fields/terms #1031

merged 1 commit into from
Feb 24, 2017

Conversation

bit
Copy link
Contributor

@bit bit commented Feb 23, 2017

use terms instead of fields as variable name to avoid confusion: NewPhraseQuery(terms []string, field string)

@bit
s/fields/terms
59f62f1 
use terms instead of fields as variable name to avoid confusion: NewPhraseQuery(terms []string, field string)
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2017
@ethantkoenig
Copy link
Member

@bit I was the one who wrote this code, and I didn't realize there was a clash of terminology; thanks!

@lunny lunny added this to the 1.1.0 milestone Feb 24, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 24, 2017
@lunny
Copy link
Member

lunny commented Feb 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2017
@lunny lunny merged commit 490d377 into go-gitea:master Feb 24, 2017
@ethantkoenig ethantkoenig mentioned this pull request Feb 24, 2017
Merged
@bit bit deleted the patch-1 branch February 24, 2017 04:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bit @ethantkoenig @lunny @tboerger