Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix head.tmpl og:image picture location #10531

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix head.tmpl og:image picture location #10531

merged 1 commit into from
Feb 28, 2020

Conversation

freecipher
Copy link
Contributor

@freecipher freecipher commented Feb 28, 2020 •
edited
Loading

og:image picture location

@freecipher
head.tmpl og:image picture location
aa069f1 
og:image picture location
@codecov-io
Copy link

Codecov Report

Merging #10531 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10531      +/-   ##
==========================================
+ Coverage   43.68%   43.68%   +<.01%     
==========================================
  Files         586      586              
  Lines       81521    81521              
==========================================
+ Hits        35612    35615       +3     
+ Misses      41494    41492       -2     
+ Partials     4415     4414       -1
Impacted Files Coverage Δ
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
services/pull/pull.go 35.19% <0%> (-0.88%) ⬇️
models/error.go 29.23% <0%> (+0.51%) ⬆️
modules/indexer/issues/indexer.go 58.9% <0%> (+1.36%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2059a...aa069f1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@lunny
Copy link
Member

lunny commented Feb 28, 2020

make L-G-T-M work

@lunny lunny merged commit 74433c9 into go-gitea:master Feb 28, 2020
@lunny
Copy link
Member

lunny commented Feb 28, 2020

@freecipher Please send backport to release/v1.11

@jolheiser jolheiser mentioned this pull request Feb 28, 2020
Closed
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Mar 1, 2020
@freecipher @6543
head.tmpl og:image picture location (go-gitea#10531)
120c09f 
og:image picture location
@6543 6543 mentioned this pull request Mar 1, 2020
Merged
@6543
Copy link
Member

6543 commented Mar 1, 2020

@freecipher created backport for you: #10556

techknowlogick pushed a commit that referenced this pull request Mar 1, 2020
@6543 @freecipher
head.tmpl og:image picture location (#10531) (#10556)
db26f0a 
* head.tmpl og:image picture location (#10531)

og:image picture location

* CI.restart()

* CI.restart()

Co-authored-by: FreeCipher <[email protected]>
@guillep2k guillep2k added the backport/done All backports for this PR have been created label Mar 1, 2020
@zeripath zeripath changed the title head.tmpl og:image picture location Fix head.tmpl og:image picture location Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@freecipher @codecov-io @lunny @6543 @zeripath @guillep2k @GiteaBot