Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused vars #1063

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Remove unused vars #1063

merged 2 commits into from
Feb 27, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 26, 2017

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 26, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 26, 2017
@appleboy
Copy link
Member

LGTM

@appleboy
Copy link
Member

let L-G-T-M work

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 26, 2017
@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2017
@lunny
Copy link
Member Author

lunny commented Feb 26, 2017

It seems drone down

@tboerger
Copy link
Member

But these vars should be used by protected branches

@lunny
Copy link
Member Author

lunny commented Feb 26, 2017

No. It's no need and no reference any more since I refactor the protected branch in #1030

@tboerger
Copy link
Member

OK, LGTM

@lunny
Copy link
Member Author

lunny commented Feb 26, 2017

but it seems drone down.

@tboerger
Copy link
Member

Maybe do some force push to retrigger a build. Other prs have been tested fine

@lunny
Copy link
Member Author

lunny commented Feb 27, 2017

let L-G-T-M work

@lunny lunny merged commit e4134de into go-gitea:master Feb 27, 2017
@lunny lunny deleted the lunny/remove_unused_vars branch February 27, 2017 01:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @appleboy @thibaultmeyer @tboerger