Forcibly clean and destroy the session on logout #11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
guillep2k
approved these changes
May 16, 2020
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
May 17, 2020
GiteaBot
added
lgtm/done
|
need backport |
zeripath
commented
May 17, 2020
|
Ah I think I understand! We don't necessarily have to destroy the session completely if we prevent the session cookie from being set. I still think destroy is correct though |
|
make L-G-T-M work |
|
Please send backport to v1.11 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 17, 2020
Backport go-gitea#11447 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
May 17, 2020
Backport #11447 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: techknowlogick <[email protected]>
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
May 17, 2020
Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Thornton [email protected]