Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whenever the ctx.Session is updated, release to save before sending the redirect #11456

Conversation

zeripath
Copy link
Contributor

Fixes intermittent 500s in Oauth2/OpenID enrollment and TwoFA.

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added this to the 1.12.0 milestone May 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@lafriks lafriks merged commit 76053ac into go-gitea:master May 17, 2020
@lunny
Copy link
Member

lunny commented May 17, 2020

Please send back port to v1.11

@zeripath zeripath deleted the fix-intermittent-500-due-to-session-out-of-date branch May 17, 2020 13:35
zeripath added a commit to zeripath/gitea that referenced this pull request May 17, 2020
…ding the redirect (go-gitea#11456)

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label May 17, 2020
lunny pushed a commit that referenced this pull request May 17, 2020
…ding the redirect (#11456) (#11457)

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…ding the redirect (go-gitea#11456)

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants