Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent font size for markdown preview on new PR view #11565

Merged
merged 3 commits into from
May 24, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 22, 2020

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2020
@zeripath
Copy link
Contributor

$ grep -Rh font-size web_src/less | sed -e 's/^ *//' | sort | uniq                           [09:41:35]
font-size: 100%;
font-size: 1.1em;
font-size: 11px;
font-size: 1.25em;
font-size: 128px;
font-size: 1.2em;
font-size: 12px;
font-size: 13px;
font-size: 1.3rem;
font-size: 1.4em;
font-size: 14px;
font-size: 1.5em;
font-size: 15px;
font-size: 1.5rem;
font-size: 16px;
font-size: 1.6rem;
font-size: 1.75em;
font-size: 1.7em;
font-size: 1em;
font-size: 1rem;
font-size: 20px;
font-size: 21px;
font-size: 2.25em;
font-size: 2.3rem;
font-size: 2em;
font-size: 3.5em;
font-size: 36px;
font-size: 3em;
font-size: 5.5em;
font-size: .5em;
font-size: .75em;
font-size: .7em;
font-size: 85%;
font-size: .85714286rem;
font-size: .8em;
font-size: .8rem;
font-size: .92857143rem;
font-size: .9rem;
font-size: inherit;
#git-graph-container li .time {color:#999999;font-size:80%}

Ugh

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2020
@zeripath zeripath added topic/ui Change the appearance of the Gitea UI backport/v1.12 labels May 24, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 24, 2020
@zeripath
Copy link
Contributor

Thanks @CirnoT

In order to reduce the delays for merging I wonder if we could try to bunch some of these styling fixes (for at least the backports.)

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 04afd9d into go-gitea:master May 24, 2020
@CirnoT CirnoT deleted the repo-pull-markdown branch May 24, 2020 17:53
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 25, 2020
…tea#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 25, 2020
techknowlogick pushed a commit that referenced this pull request May 26, 2020
* Fix inconsistent font size for markdown preview on new PR view (#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)

* Fix margin on PR form (#11566)

(cherry picked from commit f2a0be1)

* Fix margin for attached top header on code review (#11571)

Introduced naively by #11463

The margin was being applied too widely.

(cherry picked from commit e682a92)

* Fix styling for PR merge section when no checks (#11609)

Makes styling consistent between two cases. Also removed unnecessary double border.

* Normalize avatar radius
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…tea#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants