Work around fomantic 2.8.5 bugs

[CirnoT]

Closes #11759

fomantic/Fomantic-UI#1372 and fomantic/Fomantic-UI#1473

Before:

After:

[CirnoT]

The slight change in icon alignment is caused by fomantic/Fomantic-UI@c9e768d

[silverwind]

Any related Fomantic issues for these? Maybe fomantic/Fomantic-UI#1502?

[CirnoT]

Yes that's the one for dropdown, as for icon vertical align, not sure it can be considered bug on Fomantic end aside from the fact that change was introduced in patch release.

For icon alignment looks like just a change on FA side, most likely they won't consider it as bug either.

[lubber-de]

Holy! 👀 We'll look into and will fix the dropdown issue asap! (although the left menu fix will also work (has no impact) in 2.8.4)

Regarding the icon issue, i cannot reproduce the drastical icon alignment difference as shown in your screenshots of gitea

I prepared 2 little jsfiddles out of the relevant gitea template code for the merge button and the underlying out-of-date info

I also see a slight difference in vertical positioning, but not as much as in your code. Am i missing some additional gitea class here? We will investigate, if we will revert the icon vertical align change .

2.8.4 OK

https://jsfiddle.net/usfh3tpw

2.8.5 Around 2px difference

https://jsfiddle.net/usfh3tpw/1/

Gitea Screenhots (around 16px difference)

[lubber-de]

We fixed the icon alignment by fomantic/Fomantic-UI#1503

[CirnoT]

@lubber-de The exclamation mark in your fiddle uses standard icon, but we use <svg> there.

2.8.4: https://jsfiddle.net/uzkmheLo/
2.8.5: https://jsfiddle.net/eokpj6rz/1/

[zeripath]

make lg-tm work

[lubber-de]

Fomantic-UI 2.8.6 has just been released which should fix the issues in the core now.

[silverwind]

Thanks! @CirnoT would you like to attempt this upgrade, removing workarounds where possible?