Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause, Resume, Release&Reopen, Add and Remove Logging from command line #11777

Merged
merged 10 commits into from
Jul 6, 2020
Merged

Pause, Resume, Release&Reopen, Add and Remove Logging from command line #11777

merged 10 commits into from
Jul 6, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 5, 2020 •
edited
Loading

Provide manager commands to:

  • Release-and-reopen files and connections for logging
  • Pause logging
  • Resume logging
  • Add a new logger
  • Remove a logger

Adds a binding to SIGUSR1 to cause gitea to release and reopen its log files. (Please note this is not kill -1 - that causes a graceful restart - but rather kill -USR1 or kill -10.)

Fix #9960
Fix #1437
Related and will unblock #9930

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 5, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 5, 2020
@zeripath zeripath changed the title Pause logging Pause, Resume, Add and Remove Logging from command line Jun 5, 2020
techknowlogick
techknowlogick reviewed Jun 6, 2020
View reviewed changes
modules/private/manager.go Outdated Show resolved Hide resolved
modules/private/manager.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2020
zeripath
zeripath commented Jun 6, 2020
View reviewed changes
cmd/manager.go Outdated Show resolved Hide resolved
@zeripath zeripath changed the title Pause, Resume, Add and Remove Logging from command line Pause, Resume, Release&Reopen, Add and Remove Logging from command line Jun 12, 2020
techknowlogick
techknowlogick approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Code is great and when going through the functionality on a local build it works as expected (and documented!). Thank you!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2020
@techknowlogick techknowlogick merged commit c5b08f6 into go-gitea:master Jul 6, 2020
@zeripath zeripath deleted the pause-logging branch July 6, 2020 08:34
@zeripath zeripath mentioned this pull request Jul 6, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@zeripath @techknowlogick @lafriks
Pause, Resume, Release&Reopen, Add and Remove Logging from command li…
5c46132 
…ne (go-gitea#11777)

* Make LogDescriptions race safe

* Add manager commands for pausing, resuming, adding and removing loggers

Signed-off-by: Andrew Thornton <[email protected]>

* Placate lint

* Ensure that file logger is run!

* Add support for smtp and conn

Signed-off-by: Andrew Thornton <[email protected]>

* Add release-and-reopen

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Feature & Proposal] Halting Log Output and Graceful Restart/Stop Reload Log Files
4 participants
@zeripath @techknowlogick @lafriks @GiteaBot