Use ID or Where to instead directly use Get when load object from database #11925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Jun 17, 2020
GiteaBot
added
the
lgtm/need 1
6543
reviewed
Jun 17, 2020
Co-authored-by: 6543 <[email protected]>
6543
approved these changes
Jun 17, 2020
GiteaBot
added
lgtm/done
|
🚀 |
lafriks
approved these changes
Jun 17, 2020
|
Please send backports |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jun 17, 2020
…abase (go-gitea#11925) * Use ID or Where to instead directly use Get when load object from database * Apply suggestions from code review Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]>
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jun 17, 2020
…abase (go-gitea#11925) * Use ID or Where to instead directly use Get when load object from database * Apply suggestions from code review Co-authored-by: 6543 <[email protected]>
zeripath
pushed a commit
that referenced
this pull request
Jun 17, 2020
…abase (#11925) (#11934) Backport #11925 Use ID or Where to instead directly use Get when load object from database Co-authored-by: Lunny Xiao <[email protected]>
zeripath
pushed a commit
that referenced
this pull request
Jun 17, 2020
…abase (#11925) (#11935) Backport #11925 Use ID or Where to instead directly use Get when load object from database Co-authored-by: Lunny Xiao <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…abase (go-gitea#11925) * Use ID or Where to instead directly use Get when load object from database * Apply suggestions from code review Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Fix #11921