Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a few more eslint rules #12145

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Enable a few more eslint rules #12145

merged 2 commits into from
Jul 5, 2020

Conversation

silverwind
Copy link
Member

This gets the config closer to what 1.12 had.

Related: #12129

@silverwind
Enable a few more eslint rules
17801cd 
This gets the config closer to what 1.12 had.

Related: go-gitea#12129
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2020
@zeripath
Copy link
Contributor

zeripath commented Jul 5, 2020

make lg-tm work

@zeripath zeripath merged commit 15d3aa7 into go-gitea:master Jul 5, 2020
@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 5, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jul 5, 2020
@silverwind silverwind deleted the eslinttweak branch July 5, 2020 13:37
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
Enable a few more eslint rules (go-gitea#12145)
7e405da 
This gets the config closer to what 1.12 had.

Related: go-gitea#12129
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @zeripath @lunny @GiteaBot