Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust margin-top for repo header label #12174

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Adjust margin-top for repo header label #12174

merged 1 commit into from
Jul 7, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jul 7, 2020

Very minor, mirror what Fomantic does for normal .header class:

.ui.header > .ui.label {
    margin-top: -.29165em;
}

Before:
firefox_2020-07-07_11-10-36

After:
firefox_2020-07-07_11-10-51

The screenshots don't show it very well but the label is not ideally centered without this adjustement.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 7, 2020
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2020
@lunny lunny merged commit 88ef04d into go-gitea:master Jul 7, 2020
@CirnoT CirnoT deleted the repo-header_label-marg branch July 7, 2020 12:22
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Adjust margin-top for repo header label (go-gitea#12174)
409a8ae
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CirnoT @lunny @silverwind @GiteaBot