Rename models.ProtectedBranchRepoID/PRID to models.EnvRepoID/PRID and ensure EnvPusherEmail is set

[zeripath]

models.ProtectedBranchRepoID is poorly named as it has nothing to do with protected branch and is only the RepoID.

Also we only intermittently set the EnvPusherEmail - this ensures that this is set.

We should probably consider whether the EnvPusherEmail should be set all the time instead of only if KeepEmailPrivate is not set.

Signed-off-by: Andrew Thornton [email protected]

[codecov-commenter]

Codecov Report

Merging #12646 into master will decrease coverage by 0.02%.
The diff coverage is 30.43%.

@@            Coverage Diff             @@
##           master   #12646      +/-   ##
==========================================
- Coverage   43.46%   43.44%   -0.03%     
==========================================
  Files         645      645              
  Lines       71329    71345      +16     
==========================================
- Hits        31006    30995      -11     
- Misses      35312    35341      +29     
+ Partials     5011     5009       -2     

Impacted Files	Coverage Δ
cmd/hook.go	0.00% <0.00%> (ø)
cmd/serv.go	2.85% <0.00%> (-0.03%)	⬇️
models/branches.go	43.01% <ø> (ø)
modules/private/serv.go	0.00% <ø> (ø)
routers/private/serv.go	29.30% <0.00%> (-1.35%)	⬇️
models/helper_environment.go	93.10% <100.00%> (+0.79%)	⬆️
routers/repo/http.go	42.96% <100.00%> (ø)
models/repo_mirror.go	2.38% <0.00%> (-11.91%)	⬇️
modules/cron/tasks_basic.go	87.35% <0.00%> (-3.45%)	⬇️
models/unit.go	46.57% <0.00%> (-2.74%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fbbe9...20443cc. Read the comment docs.