Fix attachments list in edit comment

[zeripath]

#11141 broke the appearance of dropzone attachments when editting
comments causing poorly updating lists.

This PR fixes this.

Fix #12583

Signed-off-by: Andrew Thornton [email protected]

[zeripath]

could be backported to 1.12

[codecov-commenter]

Codecov Report

Merging #13036 into master will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master   #13036      +/-   ##
==========================================
- Coverage   42.62%   42.61%   -0.01%     
==========================================
  Files         672      672              
  Lines       73785    73795      +10     
==========================================
- Hits        31448    31447       -1     
- Misses      37247    37256       +9     
- Partials     5090     5092       +2     

Impacted Files	Coverage Δ
modules/upload/upload.go	78.94% <90.00%> (+2.35%)	⬆️
routers/repo/issue.go	36.86% <100.00%> (ø)
modules/indexer/stats/db.go	52.17% <0.00%> (-17.40%)	⬇️
modules/log/event.go	56.60% <0.00%> (-0.95%)	⬇️
models/repo_list.go	78.57% <0.00%> (-0.90%)	⬇️
models/error.go	34.34% <0.00%> (-0.51%)	⬇️
modules/util/timer.go	100.00% <0.00%> (+14.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1c51c...5166d48. Read the comment docs.

[zeripath]

Unfortunately I don't think this is a fix for #12573 but rather is a fix for #12583.

I'm still struggling to completely replicate #12573

[codecov-io]

Codecov Report

Merging #13036 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #13036      +/-   ##
==========================================
+ Coverage   42.60%   42.62%   +0.01%     
==========================================
  Files         673      673              
  Lines       73862    73868       +6     
==========================================
+ Hits        31470    31483      +13     
  Misses      37275    37275              
+ Partials     5117     5110       -7     

Impacted Files	Coverage Δ
modules/upload/upload.go	77.35% <83.33%> (+0.76%)	⬆️
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
models/repo_mirror.go	2.38% <0.00%> (-11.91%)	⬇️
modules/cron/tasks_basic.go	87.35% <0.00%> (-3.45%)	⬇️
services/mirror/mirror.go	18.51% <0.00%> (-1.35%)	⬇️
services/pull/pull.go	40.78% <0.00%> (ø)
models/issue_comment.go	53.75% <0.00%> (+0.30%)	⬆️
models/error.go	34.85% <0.00%> (+0.50%)	⬆️
modules/log/event.go	61.79% <0.00%> (+0.94%)	⬆️
modules/queue/workerpool.go	60.00% <0.00%> (+1.22%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f27849...b1ff337. Read the comment docs.

[6543]

It makes sittuation better!

but now I get this relicts after editing (no page reload):

☝️ edit add second image

after a page reload all looks fine

[zeripath]

@6543 That's odd... are you sure your javascript is up to date?

[6543]

Yes

[zeripath]

What does yes mean?

[6543]

I have tested the this patch on a fresh browser so there should be no old java in the cache ...

[zeripath]

Check the DOM and tell me where those nodes are and what they are contained in.

[zeripath]

I've managed to reproduce ... give me a few mins.

[zeripath]

Now there's one other weird thing this PR doesn't sort which is handling what happens when you remove an attachment from an empty comment... That appears not to happen unless you add some content at the same time. (which is now properly handled.)

[zeripath]

OK @6543 ready again.

[6543]

wow - thanks!!

[6543]

🎉