Disable DSA ssh keys by default #13056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSH has disabled DSA keys since version 7.0 As the docker runs openssh > v7.0 we should just disable DSA keys by default. Refers to go-gitea#11417 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
the
topic/distribution
techknowlogick
approved these changes
Oct 6, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
changed the title
|
We could just go even further and disable DSA keys by default for Gitea |
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
zeripath
added
the
pr/breaking
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #13056 +/- ##
==========================================
+ Coverage 42.59% 42.63% +0.03%
==========================================
Files 672 672
Lines 73785 73787 +2
==========================================
+ Hits 31428 31458 +30
+ Misses 37260 37233 -27
+ Partials 5097 5096 -1
Continue to review full report at Codecov.
|
|
Tests need updating TestAddReadOnlyDeployKey |
lafriks
approved these changes
Oct 9, 2020
GiteaBot
added
lgtm/done
6543
added
the
topic/security
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSH has disabled DSA keys since version 7.0
DSA keys are considered insecure - we should therefore disable these by default. This means we need to turn on minimum key size checks by default too.
Fix #11417
Signed-off-by: Andrew Thornton [email protected]