Show outdated comments in pull request

[ivanvc]

This PR addresses issue #12523. Outdated comments are expanded by default and added an "Outdated" label to them. Resolved comments are collapsed by default. This is how it initially looks when loading the pull request:

• The first comment was marked as resolved.
• The second comment is outdated as that line was changed in a commit.
• The last comment is neither resolved nor outdated.

Fixes #12523.

[codecov-io]

Codecov Report

Merging #13148 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13148      +/-   ##
==========================================
+ Coverage   41.97%   42.08%   +0.10%     
==========================================
  Files         681      681              
  Lines       75121    75121              
==========================================
+ Hits        31535    31611      +76     
+ Misses      38456    38359      -97     
- Partials     5130     5151      +21     

Impacted Files	Coverage Δ
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
modules/log/event.go	59.90% <0.00%> (-1.89%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
services/pull/check.go	49.63% <0.00%> (-1.46%)	⬇️
models/error.go	34.39% <0.00%> (ø)
services/pull/pull.go	41.27% <0.00%> (+0.49%)	⬆️
modules/git/repo.go	47.71% <0.00%> (+1.01%)	⬆️
services/mailer/mail.go	55.91% <0.00%> (+1.07%)	⬆️
modules/notification/notification.go	81.25% <0.00%> (+2.67%)	⬆️
modules/notification/base/null.go	71.42% <0.00%> (+2.85%)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a3785...6d5e846. Read the comment docs.

[zeripath]

IMO could be backported to 1.13 as it's been a long-term gripe for users.

[lafriks]

what the hell... I did press update branch but it somehow got merged :/

[lafriks]

please send backport to release/v1.13 branch

[ivanvc]

@lafriks I'll start a new PR as I can't re-open this one. However, I was thinking if I should refactor, or create a generic "tag" css class as the same style is used in at least three places. I didn't do it before, because couldn't find a place in the css where the style for the basic elements is defined.

Thoughts? Or should I just keep it as is?

[6543]

@ivanvc I'll have done the backport for you :)

git fetch --all
git checkout -f upstream/release/v1.13 -b backport_show-outdated-comments-in-pull-request_131
git cherry-pick -S 05c7e58
git push -u own backport_show-outdated-comments-in-pull-request_13148

-> #13162

---

"... I can't re-open ..."

@ivanvc pleace do a new pull for each task/issue - and yes refactors are welcome too :)

[ivanvc]

@6543 Cool, thanks. I'll refactor later the CSS to make it more standard and open a PR against master, as I guess it is just an improvement.