Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations should not fail for comment reactions #13352

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Oct 29, 2020

An extension to #13344 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton [email protected]

An extension to go-gitea#13444 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #13352 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13352      +/-   ##
==========================================
- Coverage   42.12%   42.10%   -0.02%     
==========================================
  Files         689      689              
  Lines       75851    75856       +5     
==========================================
- Hits        31949    31936      -13     
- Misses      38670    38684      +14     
- Partials     5232     5236       +4     
Impacted Files Coverage Δ
modules/migrations/gitea_downloader.go 0.91% <0.00%> (-0.01%) ⬇️
routers/api/v1/repo/issue_reaction.go 46.76% <0.00%> (-0.69%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-2.05%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/check.go 49.63% <0.00%> (+0.72%) ⬆️
modules/avatar/avatar.go 54.76% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55801cf...cb26d20. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 29, 2020
@6543 6543 added the topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them label Oct 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 29, 2020
@techknowlogick techknowlogick merged commit 5b2096d into go-gitea:master Oct 29, 2020
@zeripath zeripath deleted the do-not-fail-migration-for-comment-reactions branch October 29, 2020 21:48
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 29, 2020
An extension to go-gitea#13444 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 29, 2020
techknowlogick pushed a commit that referenced this pull request Oct 30, 2020
An extension to #13444 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants