Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RUN_MODE prod by default (#13765) #13767

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Set RUN_MODE prod by default (#13765) #13767

merged 2 commits into from
Dec 1, 2020

Conversation

silverwind
Copy link
Member

Backport #13765 to 1.13.

@silverwind @techknowlogick
Set RUN_MODE prod by default (go-gitea#13765)
0c91967 
I think it's a bad default to have "dev" as the default run mode which
enables debugging and now also disables HTTP caching. It's better to
just default to a value suitable for general deployments.

Co-authored-by: techknowlogick <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2020
@silverwind
Copy link
Member Author

Actually, it seems I need to flip around the pref in routers/init.go so new default takes effect.

@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 30, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Nov 30, 2020
@silverwind
Copy link
Member Author

Hold on :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2020
@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 30, 2020
@silverwind
Copy link
Member Author

Done. Will forward-port this as well, sorry I missed it.

@silverwind silverwind mentioned this pull request Nov 30, 2020
Merged
@lunny lunny merged commit d475b65 into go-gitea:release/v1.13 Dec 1, 2020
@silverwind silverwind deleted the backport-13765 branch December 1, 2020 08:38
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @jolheiser @lunny @GiteaBot