Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected branches with templates #14334

Closed
wants to merge 6 commits into from

Conversation

jolheiser
Copy link
Member

Will resolve #14303

Branch protection can only be generated if git content is generated due to needing a branch and therefore a commit.

@jolheiser jolheiser added type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Jan 14, 2021
@jolheiser jolheiser added this to the 1.15.0 milestone Jan 14, 2021
@jolheiser jolheiser removed the pr/wip This PR is not ready for review label Jan 14, 2021
@jolheiser jolheiser changed the title WIP: Protected branches with templates Protected branches with templates Jan 14, 2021
models/repo_generate.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2021
@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

Merging #14334 (dbf9a63) into master (b2c20b6) will increase coverage by 0.00%.
The diff coverage is 28.16%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14334   +/-   ##
=======================================
  Coverage   42.11%   42.12%           
=======================================
  Files         758      758           
  Lines       81085    81128   +43     
=======================================
+ Hits        34148    34172   +24     
- Misses      41360    41383   +23     
+ Partials     5577     5573    -4     
Impacted Files Coverage Δ
models/repo.go 52.32% <0.00%> (-0.09%) ⬇️
models/repo_generate.go 9.09% <0.00%> (-3.41%) ⬇️
modules/forms/repo_form.go 37.74% <ø> (ø)
modules/repository/generate.go 0.00% <0.00%> (ø)
routers/repo/repo.go 31.25% <0.00%> (-0.14%) ⬇️
services/repository/generate.go 0.00% <0.00%> (ø)
models/branches.go 42.12% <80.95%> (+0.75%) ⬆️
models/org_team.go 55.35% <100.00%> (+0.16%) ⬆️
modules/indexer/stats/db.go 48.00% <0.00%> (-8.00%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c20b6...dbf9a63. Read the comment docs.

@tomaswarynyca
Copy link
Contributor

@jolheiser Please resolve the conflicts.

models/branches.go Outdated Show resolved Hide resolved
Signed-off-by: jolheiser <[email protected]>
@techknowlogick techknowlogick modified the milestones: 1.15.0, 1.16.0 Jun 15, 2021
@jolheiser jolheiser mentioned this pull request Jul 14, 2021
@lunny
Copy link
Member

lunny commented Nov 9, 2021

Please resolve the conflicts.

@techknowlogick techknowlogick modified the milestones: 1.16.0, 1.17.0 Nov 23, 2021
@stale
Copy link

stale bot commented May 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label May 1, 2022
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 3, 2022
@stale stale bot removed the issue/stale label Jun 3, 2022
@lunny lunny modified the milestones: 1.17.0, 1.18.0 Jun 3, 2022
@lunny lunny removed this from the 1.18.0 milestone Oct 17, 2022
@lunny lunny added this to the 1.19.0 milestone Oct 17, 2022
@lunny lunny removed this from the 1.19.0 milestone Feb 1, 2023
@lunny
Copy link
Member

lunny commented May 9, 2023

This PR outdated.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy branch configuration from the template
7 participants