Disable broken OAuth2 providers at startup #14802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of causing a log.Fatal, we should handle broken OAuth2 providers by disabling them. Fix go-gitea#8930 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
Feb 25, 2021
GiteaBot
added
the
lgtm/need 1
a1012112796
approved these changes
Feb 26, 2021
GiteaBot
added
lgtm/done
…-startup-instead-of-fatalling
|
🚀 |
zeripath
deleted the
fix-8930-Disable-broken-oauth-providers-at-startup-instead-of-fatalling
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 26, 2021
Backport go-gitea#14802 Instead of causing a log.Fatal, we should handle broken OAuth2 providers by disabling them. Fix go-gitea#8930 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
6543
pushed a commit
that referenced
this pull request
Feb 26, 2021
Backport #14802 Instead of causing a log.Fatal, we should handle broken OAuth2 providers by disabling them. Fix #8930 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.
Fix #8930
Signed-off-by: Andrew Thornton [email protected]