Remove random password in Dockerfiles #15362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile contained a random password to unlock the
git
user account. Otherwise the OpenSSH server would complain about a locked account (#377).A locked account is marked by a
!
at the start off the password hash. An alternative is the password hash*
. Both are invalidcrypt
password hashes and therefore no login via password is possible. The!
has the additional meaning of an locked account, whereas*
just means no login. Seeshadow(5)
.Additionally the rootless Dockerfile uses the embedded SSH server. And I think the embedded SSH server does not depend on the
git
user password at all. Therefore we can leave the password at the default (disabled and locked via!
).ToDo:
If the rootless image does not work, revert 04390f5