Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove x-ua-compatible meta tag #15640

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Remove x-ua-compatible meta tag #15640

merged 1 commit into from
Apr 28, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 27, 2021 •
edited
Loading

The header is deprecated since IE 11 so it only serves to support IE 10 and below which are browsers which are long unsupported now.

Ref: https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/dev-guides/bg182625(v=vs.85)#document-mode-changes

Starting with IE11, edge mode is the preferred document mode; it represents the highest support for modern standards available to the browser.

Starting with IE11, document modes are deprecated and should no longer be used, except on a temporary basis.

@silverwind
Remove x-ua-compatible header
920fd06 
The header is deprecated since IE 11 so it only serves to support IE 10
and below which are browsers which are long unsupported now.
@silverwind silverwind added this to the 1.15.0 milestone Apr 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 27, 2021
@silverwind silverwind changed the title Remove x-ua-compatible header Remove x-ua-compatible meta tag Apr 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2021
@lafriks lafriks merged commit cc7d118 into go-gitea:master Apr 28, 2021
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 28, 2021
@silverwind silverwind deleted the rm-ie10 branch April 28, 2021 06:13
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @techknowlogick @lafriks @GiteaBot