Include --work-path flag in commands in authorized_keys #15978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the tests are failing a comparison check. Can you please update them? 🙂 |
GiteaBot
added
the
lgtm/need 2
|
Sorry about that, I neglected to run |
|
I'm really not certain that this is necessary. Why are you needing this? Gitea Serv and Hook shouldn't really need any thing that depends of AppWorkPath. Could you please explain |
|
I explained in the linked issue. gitea definitely needs to know where my repositories are, and in the default config, those are defined relative to AppWorkPath.
…On May 26, 2021 2:57:10 PM EDT, zeripath ***@***.***> wrote:
I'm really not certain that this is necessary.
Why are you needing this? Gitea Serv and Hook shouldn't really need any thing that depends of AppWorkPath.
Could you please explain
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#15978 (comment)
|
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 27, 2021
Fix go-gitea#15595 Replaces go-gitea#15978 Signed-off-by: Andrew Thornton <[email protected]>
|
I've made a PR that makes the authorized_keys command a template - allowing you to add work-path or other things as needed |
techknowlogick
added a commit
that referenced
this pull request
Jun 15, 2021
Fix #15595 Replaces #15978 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
|
Closing per merge of linked PR |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Fix go-gitea#15595 Replaces go-gitea#15978 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15973