Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html.Parse rather than html.ParseFragment #16223

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

zeripath
Copy link
Contributor

There have been a few issues with html.ParseFragment - just use html.Parse instead.

Signed-off-by: Andrew Thornton [email protected]

There have been a few issues with html.ParseFragment - just use html.Parse instead.

Signed-off-by: Andrew Thornton <[email protected]>
@6543

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2021
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath force-pushed the fix-issue-with-parse-fragment branch from 1e3ef95 to e94fa87 Compare June 21, 2021 20:34
@zeripath
Copy link
Contributor Author

Should be fixed now. The issue is that the Parse adds a document node which we need to skip.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2021
@6543 6543 merged commit d55b5eb into go-gitea:main Jun 21, 2021
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jun 21, 2021
* Use html.Parse rather than html.ParseFragment
  There have been a few issues with html.ParseFragment - just use html.Parse instead.

* Skip document node

Signed-off-by: Andrew Thornton <[email protected]>
@6543 6543 added the backport/done All backports for this PR have been created label Jun 21, 2021
@6543
Copy link
Member

6543 commented Jun 21, 2021

-> #16225

lunny pushed a commit that referenced this pull request Jun 22, 2021
* Use html.Parse rather than html.ParseFragment
  There have been a few issues with html.ParseFragment - just use html.Parse instead.

* Skip document node

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: zeripath <[email protected]>
@zeripath zeripath deleted the fix-issue-with-parse-fragment branch June 22, 2021 06:04
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Use html.Parse rather than html.ParseFragment
  There have been a few issues with html.ParseFragment - just use html.Parse instead.

* Skip document node

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants