Change docker tag logic #16421
Merged
Change docker tag logic #16421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
GiteaBot
added
the
lgtm/need 2
3 tasks
techknowlogick
added
the
pr/breaking
lafriks
approved these changes
Jul 14, 2021
GiteaBot
added
lgtm/need 1
kdumontnu
suggested changes
Jul 14, 2021
Co-authored-by: Kyle D. <[email protected]>
|
@kdumontnu docs have been updated :) |
kdumontnu
reviewed
Jul 14, 2021
kdumontnu
approved these changes
Jul 14, 2021
GiteaBot
added
lgtm/done
sapk
approved these changes
Jul 14, 2021
|
Wait, do the manifest/docker plugins have the logic to not tag |
|
No it does not have |
|
That was quick in the end 😅 👍 |
|
@kdumontnu it is a problem already existing previously and we always have to re-build a latest. |
6 tasks
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Change docker logic * Apply suggestions from code review Co-authored-by: Kyle D. <[email protected]> * docs Co-authored-by: 6543 <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: Kyle D. <[email protected]>
|
Thank god! This makes so much more sense now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the image tagged as
:lateston docker hub to represent the:latestreleased version of Gitea.:latestwill now be mapped to latest tag on the 1.15 branch.:devwill represent the latest build from themainbranch.Replace: #15889
Fixes #15622
thanks to @pat-s for the initial work on this PR :)
Previously the
:latestdocker tag would map to the latest build frommain. Users who wish to use the absolute latest version of Gitea should migrate to use:devand we would ask that at least some users do consider using the:devtag if possible.