Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default cron schedules from @every 24h to @midnight #16431

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Jul 14, 2021

The basic maintenance crons are scheduled @every 24h by default:
https://docs.gitea.io/en-us/config-cheat-sheet/#basic-cron-tasks---enabled-by-default

In practice, this means they will be triggered every 24h from the time that gitea has started. A better default for these would be to perform these tasks at midnight instead.

Fixes #16107.

⚠️ BREAKING ⚠️

The default schedule for basic cron tasks will now occur at midnight rather than at 24 hours after start-up.

At time of merging this changes the defaults for:

cron.archive_cleanup
cron.repo_health_check
cron.check_repo_stats
cron.cleanup_hook_task_table
cron.update_migration_poster_id
cron.sync_external_users

@techknowlogick techknowlogick added this to the 1.16.0 milestone Jul 14, 2021
@codecov-commenter

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2021
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jul 14, 2021
@zeripath zeripath added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jul 15, 2021
@zeripath
Copy link
Contributor

We need to get better at making the first comment in a PR represent what the PR is doing to explain to future readers what the aim and intention of the PR was.

As this is technically breaking I've added the breaking label and a breaking section to the first comment.

@zeripath zeripath changed the title Change @every 24h default schedules to @midnight Change default cron schedules from @every 24h to @midnight Jul 15, 2021
@techknowlogick techknowlogick merged commit 8df3d65 into go-gitea:main Jul 15, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider scheduling default maintenance crons @midnight instead of @every 24h
6 participants