Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PR merge options more intuitive #16582

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

aaribaud
Copy link
Contributor

@aaribaud aaribaud commented Jul 30, 2021

Reword options making clear whether the PRed branch is rebased or not, and which type of commit will be created if any.

Fix #5863

Reword options making clear whether the PRed branch is rebased or not, and which type of commit will be created if any.
@zeripath zeripath changed the title Make PR merge options more intuitive (#5863) Make PR merge options more intuitive Jul 30, 2021
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jul 30, 2021
@zeripath zeripath added this to the 1.16.0 milestone Jul 30, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 30, 2021
@aaribaud
Copy link
Contributor Author

Not sure why the build fails. I ran it fine locally, plus the patch does not actually change any code, only locale strings.

@markkrj
Copy link

markkrj commented Jul 31, 2021

IMHO current is better, and it is consistent with git defaults.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16582 (d9a8ee8) into main (24366ed) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16582      +/-   ##
==========================================
- Coverage   45.37%   45.35%   -0.02%     
==========================================
  Files         750      750              
  Lines       85098    85098              
==========================================
- Hits        38611    38599      -12     
- Misses      40243    40254      +11     
- Partials     6244     6245       +1     
Impacted Files Coverage Δ
services/pull/temp_repo.go 30.76% <0.00%> (-3.85%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
modules/log/event.go 60.64% <0.00%> (-1.86%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (-1.15%) ⬇️
routers/web/repo/view.go 41.52% <0.00%> (+0.57%) ⬆️
modules/queue/unique_queue_disk_channel.go 48.63% <0.00%> (+1.36%) ⬆️
modules/git/blame.go 67.14% <0.00%> (+1.42%) ⬆️
models/unit.go 43.83% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24366ed...d9a8ee8. Read the comment docs.

@zeripath
Copy link
Contributor

zeripath commented Aug 2, 2021

make lgtm work

@zeripath zeripath merged commit a51cb3d into go-gitea:main Aug 2, 2021
@aaribaud aaribaud deleted the reword-pr-merge-options branch August 2, 2021 21:34
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
Reword options making clear whether the PRed branch is rebased or not, and which type of commit will be created if any.
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change name of "Rebase and Merge (--no-ff)" merge style to more meaningful one
7 participants