Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore compatibility with SQLServer 2008 R2 in migrations #16627

Merged
merged 6 commits into from
Aug 8, 2021
Merged

Restore compatibility with SQLServer 2008 R2 in migrations #16627

merged 6 commits into from
Aug 8, 2021

Commits on Aug 5, 2021

  1. Restore compatibility with SQLServer 2008 R2 in migrations 

    `ALTER TABLE DROP ... IF EXISTS ...` is only supported in SQL Server >16.

The `IF EXISTS` here is a belt-and-braces and does not need to be present. Therefore
can be dropped.

We need to figure out some way of restricting our SQL syntax against the minimum
version of SQL Server we will support.

My suspicion is that `ALTER DATABASE database_name SET COMPATIBILITY_LEVEL = 100` may
do that but there may be other side-effects so I am not whether to do that.

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    a6730ab View commit details
    Browse the repository at this point in the history

  2. try just dropping the index only 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    86bdaed View commit details
    Browse the repository at this point in the history

  3. use lowercase for system tables 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    faf0b21 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-16625-drop-if-exists

    @lafriks
    lafriks authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    765d56d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Merge branch 'main' into fix-16625-drop-if-exists

    @zeripath
    zeripath authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    8e3f084 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2021

  1. Merge branch 'main' into fix-16625-drop-if-exists

    @lunny
    lunny authored Aug 8, 2021
    Configuration menu
    Copy the full SHA
    a0a5cd5 View commit details
    Browse the repository at this point in the history