Add Horizontal scrollbar to inner menu on Chrome #17086
Conversation
There is a longstanding bug whereby the admin pages, in particular, have not had a horizontal scrollbar on chrome when the page is narrow. This PR simply adds overflow-x and adds a default height to the scrollbar to match that of the vertical bar. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
topic/ui
| @@ -181,6 +181,7 @@ details summary > * { | |||
|
|
|||
| ::-webkit-scrollbar { | |||
| width: 10px; | |||
| height: 10px; | |||
There was a problem hiding this comment.
I would assume that all scrollbars are now quadratic because of this.
Or does the scrollbar internally ignore the non-relevant setting?
There was a problem hiding this comment.
Why don't you try it?
There was a problem hiding this comment.
Am currently trying it.
Can you please point me somewhere where the horizontal scrollbars should appear?
Because right now I don't see any horizontal scrollbars on the admin pages in Chrome on a minimum width window…
There was a problem hiding this comment.
Does Chromium behave differently than Chrome here?
Because for me, the admin page looks like this:
I thought Chrome and Chromium were basically the same thing, with the only difference being that Chromium gets rid of most Google things.
There was a problem hiding this comment.
Ah, I see now:
For some reason up until about the half screen, this scrollbar will be displayed.
Only when the screen gets smaller, the tabs will be wrapped.
I would prefer unified behavior:
Either always wrap and never display the scrollbar, or never wrap and always use the scrollbar.
But that is most likely worth its own PR, so for now: lgtm.
My preference is to never use the scrollbar.
GiteaBot
added
the
lgtm/need 2
|
$ROOT_URL/admin Without 17086
With 17086
|
|
The navbar also needs some more work too. (but for another PR I think. A simple solution would be to add something like |
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
|
make lgtm work |
Backport go-gitea#17086 There is a longstanding bug whereby the admin pages, in particular, have not had a horizontal scrollbar on chrome when the page is narrow. This PR simply adds overflow-x and adds a default height to the scrollbar to match that of the vertical bar. Signed-off-by: Andrew Thornton <[email protected]>
There is a longstanding bug whereby the admin pages, in particular, have not had
a horizontal scrollbar on chrome when the page is narrow.
This PR simply adds overflow-x and adds a default height to the scrollbar to
match that of the vertical bar.
Signed-off-by: Andrew Thornton [email protected]