Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annoying areYouSure confirm caused by Chrome auto filling (failed trial) #17267

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web_src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2969,7 +2969,11 @@ $(() => {
// Warn users that try to leave a page after entering data into a form.
// Except on sign-in pages, and for forms marked as 'ignore-dirty'.
if ($('.user.signin').length === 0) {
$('form:not(.ignore-dirty)').areYouSure();
// Chrome always auto fills some inputs, and triggers `areYouSure` confirm when leaving, `autocomplete=off` doesn't help at all.
// so we can just wait for a few seconds, then the changes of the inputs are sure to be caused by real users.
Comment on lines +2972 to +2973
Copy link
Member

@silverwind silverwind Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Chrome always auto fills some inputs, and triggers `areYouSure` confirm when leaving, `autocomplete=off` doesn't help at all.
// so we can just wait for a few seconds, then the changes of the inputs are sure to be caused by real users.
// Prevent confirm dialog from triggering on browser auto-fill

Autofill is not Chrome-specific and I think this comment is descriptive enough

setTimeout(() => {
$('form:not(.ignore-dirty)').areYouSure();
}, 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}, 1000);
}, 2000);

Maybe a better compromise. I for example use BitWarden to autofill and it certainly has a bit of delay to it where 1s might not suffice. If we could somehow detect autofill, that would be an even better option but I'm not sure if it's possible.

}

// Parse SSH Key
Expand Down