Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete u2f keys pop up modal bug #18040

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 20, 2021

When delete one u2f key, then all keys delete modals popup.

Before(All modals popup at once):

image

After:

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2021
@lunny lunny changed the title Fix delete u2f keys Fix delete u2f keys pop up modal bug Dec 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2021
@zeripath zeripath merged commit ce840bb into go-gitea:main Dec 20, 2021
@zeripath
Copy link
Contributor

Please send backport - although double check that 1.15 is actually affected.

@lunny lunny deleted the lunnyfix_delete_keys branch December 20, 2021 15:44
@lunny lunny added the backport/done All backports for this PR have been created label Dec 20, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 20, 2021
Add:

* Move POST /{username}/action/{action} to simply POST /{username} (go-gitea#18045) (go-gitea#18046)
* Fix delete u2f keys bug (go-gitea#18040) (go-gitea#18042)
* Reset Session ID on login (go-gitea#18018) (go-gitea#18041)
* Prevent off-by-one error on comments on newly appended lines (go-gitea#18029) (go-gitea#18035)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Dec 20, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants